jihoonson commented on a change in pull request #8141: Use PartitionsSpec for
all task types
URL: https://github.com/apache/incubator-druid/pull/8141#discussion_r307897173
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -1243,21 +1217,60 @@ public static IndexTuningConfig createDefault()
return new IndexTuningConfig();
}
+ @Nullable
+ private static PartitionsSpec getDefaultPartitionsSpec(
+ boolean forceGuaranteedRollup,
+ @Nullable PartitionsSpec partitionsSpec,
+ @Nullable Integer maxRowsPerSegment,
+ @Nullable Long maxTotalRows,
+ @Nullable Integer numShards,
+ @Nullable List<String> partitionDimensions
+ )
+ {
+ if (partitionsSpec == null) {
+ if (forceGuaranteedRollup) {
+ if (maxRowsPerSegment != null
+ || numShards != null
+ || (partitionDimensions != null &&
!partitionDimensions.isEmpty())) {
+ return new HashedPartitionsSpec(maxRowsPerSegment, numShards,
partitionDimensions);
+ } else {
+ return null;
+ }
+ } else {
+ if (maxRowsPerSegment != null || maxTotalRows != null) {
+ return new DynamicPartitionsSpec(maxRowsPerSegment, maxTotalRows);
+ } else {
+ return null;
+ }
+ }
+ } else {
+ if (forceGuaranteedRollup) {
+ if (!(partitionsSpec instanceof HashedPartitionsSpec)) {
+ throw new ISE("HashedPartitonsSpec must be used for perfect
rollup");
Review comment:
Thanks, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
