vogievetsky commented on a change in pull request #8176: Web-console: add 
Supervisor statistics table and show json query manager
URL: https://github.com/apache/incubator-druid/pull/8176#discussion_r307945624
 
 

 ##########
 File path: web-console/src/components/show-json/show-json.tsx
 ##########
 @@ -98,7 +110,8 @@ export class ShowJson extends 
React.PureComponent<ShowJsonProps, ShowJsonState>
           </ButtonGroup>
         </div>
         <div className="main-area">
-          <TextArea readOnly value={jsonValue} />
+          {loading && <Loader />}
+          {!loading && <TextArea readOnly value={!error ? jsonValue : error} 
/>}
 
 Review comment:
   you could turn this in to a ternary `? :`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to