vogievetsky commented on a change in pull request #8164: Web-console: add history menu to supervisors modal URL: https://github.com/apache/incubator-druid/pull/8164#discussion_r307950315
########## File path: web-console/src/components/show-history/show-history.tsx ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { Tab, Tabs } from '@blueprintjs/core'; +import axios from 'axios'; +import React from 'react'; + +import { ShowJson } from '..'; + +import './show-history.scss'; + +export interface ShowHistoryProps { + endpoint: string; + transform?: (x: any) => any; + downloadFilename?: string; +} + +export interface ShowHistoryState { + jsonValue: []; + versions: any; +} + +export class ShowHistory extends React.PureComponent<ShowHistoryProps, ShowHistoryState> { + constructor(props: ShowHistoryProps, context: any) { + super(props, context); + this.state = { + versions: [], + jsonValue: [], + }; + + this.getJsonInfo(); + } + + private getJsonInfo = async (): Promise<void> => { + const { endpoint, transform, downloadFilename } = this.props; + try { + const resp = await axios.get(endpoint); + const data = resp.data; + this.setState({ + jsonValue: data, + versions: data.map((version: any, index: number) => ( + <Tab Review comment: it is a bit strange to me to render the tabs here and save them on the state, would it make more sense to just save data on the state and do the rendering in the render lifecycle? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
