leventov opened a new issue #4462: Lifecycle ordering depends on DI Module injection ordering URL: https://github.com/apache/incubator-druid/issues/4462 Lifecycle ordering must be deterministic (based on some graph), not based on Module ordering in classes like CliXxx, that could be changed even by IDE refactoring, and absolutely nothing in code points to the fact that Module ordering is important. By https://github.com/druid-io/druid/pull/4429#pullrequestreview-46105900
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
