leventov commented on a change in pull request #8129: Spotbugs:
NP_NONNULL_PARAM_VIOLATION
URL: https://github.com/apache/incubator-druid/pull/8129#discussion_r308835702
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -450,18 +450,17 @@ public Row apply(final Row row)
);
}
}, subtotalQuery, null),
- subtotalQuery
- )
+ subtotalQuery)
);
}
return Sequences.withBaggage(
Sequences.concat(subtotalsResults),
- () -> Lists.reverse(closeOnExit).forEach(closeable ->
CloseQuietly.close(closeable))
+ () -> Lists.reverse(closeOnExit).forEach(CloseQuietly::close)
);
}
catch (Exception ex) {
- Lists.reverse(closeOnExit).forEach(closeable ->
CloseQuietly.close(closeable));
+ Lists.reverse(closeOnExit).forEach(CloseQuietly::close);
Review comment:
It's better to use Closer to close multiple closeables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
