AlexanderSaydakov commented on a change in pull request #8194: HllSketch
Merge/Build BufferAggregators: Speed up init with prebuilt sketch.
URL: https://github.com/apache/incubator-druid/pull/8194#discussion_r308949053
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildBufferAggregator.java
##########
@@ -64,11 +74,27 @@ public HllSketchBuildBufferAggregator(
this.lgK = lgK;
this.tgtHllType = tgtHllType;
this.size = size;
+ this.emptySketch = new byte[size];
+
+ //noinspection ResultOfObjectAllocationIgnored (HllSketch writes to
"emptySketch" as a side effect of construction)
+ new HllSketch(lgK, tgtHllType, WritableMemory.wrap(emptySketch));
}
@Override
public void init(final ByteBuffer buf, final int position)
{
+ // Copy prebuilt empty sketch object.
+
+ final int oldPosition = buf.position();
+ try {
+ buf.position(position);
+ buf.put(emptySketch);
+ }
+ finally {
+ buf.position(oldPosition);
+ }
+
+ // Add an HllSketch for this chunk to our sketchCache.
Review comment:
ops, the above buf.put() has no effect because here a new sketch is
constructed in that memory region and also cached
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
