gianm commented on a change in pull request #8067: sql firehose and firehose
doc adjustments
URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r308970299
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/firehose/SqlFirehose.java
##########
@@ -63,8 +71,9 @@ public boolean hasMore()
@Override
public InputRow nextRow()
{
+ assert lineIterator != null;
final Map<String, Object> mapToParse = lineIterator.next();
- return Iterators.getOnlyElement(parser.parseBatch(mapToParse).iterator());
+ return
transformer.transform(Iterators.getOnlyElement(parser.parseBatch(mapToParse).iterator()));
Review comment:
Very minor, but,
```java
Iterators.getOnlyElement(parser.parseBatch(mapToParse).iterator())
```
Could be,
```java
Iterables.getOnlyElement(parser.parseBatch(mapToParse))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
