leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r310172555
########## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CoordinatorDuty.java ########## @@ -17,26 +17,25 @@ * under the License. */ -package org.apache.druid.server.coordinator.helper; +package org.apache.druid.server.coordinator.duty; +import org.apache.druid.server.coordinator.DruidCoordinator; import org.apache.druid.server.coordinator.DruidCoordinatorRuntimeParams; import javax.annotation.Nullable; /** * */ -public interface DruidCoordinatorHelper +public interface CoordinatorDuty Review comment: There are dozens of different "Helpers" in all parts of Druid. This is a meaningless term. "Duty" is a distinctive term, and it does carry some meaning - "a repetitive task that a coordinator has to do". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
