leventov commented on a change in pull request #8157: Enum of ResponseContext 
keys
URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r310212459
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/context/ResponseContext.java
 ##########
 @@ -319,7 +323,11 @@ public void merge(ResponseContext responseContext)
 
   /**
    * Serializes the context given that the resulting string length is less 
than the provided limit.
-   * This method tries to remove some elements from context collections if 
it's needed to satisfy the limit.
+   * This method removes some elements from context collections if it's needed 
to satisfy the limit.
+   * There is no explicit priorities of keys which values are being truncated 
because for now there are only
+   * two potential limit breaking keys (UNCOVERED_INTERVALS and 
MISSING_SEGMENTS) and their values are arrays.
 
 Review comment:
   Please wrap `UNCOVERED_INTERVALS` and `MISSING_SEGMENTS` with `{@link }`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to