leventov commented on a change in pull request #8235: Use Closer instead of
List<Closeable>
URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310684935
##########
File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java
##########
@@ -123,6 +123,17 @@ private Closer()
return closeable;
}
+ /**
+ * Registers a list of {@code closeable} to be closed when this {@code
Closer} is
Review comment:
If `{@code closeable}` is a reference to the interface `Closeable`, then it
should start with a capital letter. If this is a reference to the parameter,
then it should be `closeables`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
