leventov commented on a change in pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310694567
########## File path: processing/src/main/java/org/apache/druid/query/filter/BoundDimFilter.java ########## @@ -56,6 +58,7 @@ private final Supplier<DruidLongPredicate> longPredicateSupplier; private final Supplier<DruidFloatPredicate> floatPredicateSupplier; private final Supplier<DruidDoublePredicate> doublePredicateSupplier; + private final FilterTuning filterTuning; Review comment: Please annotate with `@Nullable` everything that needs to be `@Nullable` in this class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
