himanshug commented on issue #8242: should we deprecate extractionFn field in various Aggregators and Filters URL: https://github.com/apache/incubator-druid/issues/8242#issuecomment-518779310 I agree with all observations you made and road to "remove" will be a very long one as plenty of time needs to be given before they are removed. main motivator for me really is to simplify the implementation of filters and aggregators etc. I don't have anything against the API except limiting the ways of doing same things in API or else user is confused whether to use `ExtractionFnVirtualColumn` or to use `extractionFn` field, what is the difference etc etc. > We could consider getting rid of the expression field on AggregatorFactories too. Similar observations apply. actually I wrote this issue while working on https://github.com/apache/incubator-druid/pull/8243 where the context was actually `expression` and forgot to mention that one. updating the title and description.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
