clintropolis commented on a change in pull request #8222: Fix bugs in
overshadowableManager and add unit tests
URL: https://github.com/apache/incubator-druid/pull/8222#discussion_r311222756
##########
File path:
core/src/main/java/org/apache/druid/timeline/partition/OvershadowableManager.java
##########
@@ -41,18 +42,22 @@
import javax.annotation.Nullable;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.NoSuchElementException;
import java.util.Objects;
+import java.util.Set;
import java.util.TreeMap;
+import java.util.function.BiPredicate;
+import java.util.stream.Collectors;
/**
* OvershadowableManager manages the state of {@link AtomicUpdateGroup}. See
the below {@link State} for details of
- * the possible state.
+ * the possible states.
Review comment:
nit: I think
> `See the below {@link State} for details of the possible states.`
could probably just be shortened to
> `See {@link State} for details.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
