leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r311668382
##########
File path:
extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/filter/sql/BloomFilterOperatorConversion.java
##########
@@ -100,7 +100,8 @@ public DimFilter toDruidFilter(
return new BloomDimFilter(
druidExpression.getSimpleExtraction().getColumn(),
holder,
- druidExpression.getSimpleExtraction().getExtractionFn()
+ druidExpression.getSimpleExtraction().getExtractionFn(),
Review comment:
I think it's anyway strange that there is a chaining constructor and any
code is not using an existing constructor with fewer parameters.
I think it would be better to create static factory methods instead in this
situation. Some of them may have "InTest" suffix to strongly indicate that they
are not for prod code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
