jihoonson commented on a change in pull request #8038: Making optimal usage of 
multiple segment cache locations
URL: https://github.com/apache/incubator-druid/pull/8038#discussion_r312293735
 
 

 ##########
 File path: docs/content/configuration/index.md
 ##########
 @@ -1263,6 +1263,7 @@ These Historical configurations can be defined in the 
`historical/runtime.proper
 |Property|Description|Default|
 |--------|-----------|-------|
 |`druid.segmentCache.locations`|Segments assigned to a Historical process are 
first stored on the local file system (in a disk cache) and then served by the 
Historical process. These locations define where that local cache resides. This 
value cannot be NULL or EMPTY. Here is an example 
`druid.segmentCache.locations=[{"path": "/mnt/druidSegments", "maxSize": 10000, 
"freeSpacePercent": 1.0}]`. "freeSpacePercent" is optional, if provided then 
enforces that much of free disk partition space while storing segments. But, it 
depends on File.getTotalSpace() and File.getFreeSpace() methods, so enable if 
only if they work for your File System.| none |
+|`druid.segmentCache.locationSelectorStrategy`|The strategy used to select a 
location from the configured `druid.segmentCache.locations` for optimal segment 
distribution. Possible values are `leastBytesUsed` or `roundRobin`. The 
leastBytesUsed strategy always selects a location which has least bytes used in 
absolute terms.The roundRobin strategy selects a location in a round robin 
fashion oblivious to the bytes used or the capacity. |leastBytesUsed|
 
 Review comment:
   > for optimal segment distribution.
   
   nit: I don't think any strategy guarantees the "optimal" segment 
distribution here. Probably better to take it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to