jihoonson commented on a change in pull request #7792: Fix wrong order when 
ordering by string first/last agg with GroupBy V2
URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r314513318
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java
 ##########
 @@ -51,6 +52,11 @@
 
   public abstract Comparator getComparator();
 
+  public Comparator makeComparatorWithOrderByColumnSpec(OrderByColumnSpec 
columnSpec)
 
 Review comment:
   I would suggest to rename this to `getComparatorForFinalOrdering()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to