pjain1 commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r315058737
##########
File path:
server/src/main/java/org/apache/druid/client/indexing/ClientTaskQuery.java
##########
@@ -28,15 +28,15 @@
* at the moment of making a REST query: {@link
HttpIndexingServiceClient#runTask} serializes ClientTaskQuery
* objects and
org.apache.druid.indexing.overlord.http.OverlordResource.taskPost() deserializes
* org.apache.druid.indexing.common.task.Task objects from the same bytes.
Therefore JSON serialization fields of
- * ClientTaskQuery objects must match with those of the corresponding
- * org.apache.druid.indexing.common.task.Task objects.
+ * ClientTaskQuery objects must match with those of the corresponding
org.apache.druid.indexing.common.task.Task
+ * objects.
*/
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
@JsonSubTypes(value = {
- @Type(name = "kill", value = ClientKillQuery.class),
- @Type(name = "compact", value = ClientCompactQuery.class)
+ @Type(name = "kill", value = ClientKillUnusedSegmentsTaskQuery.class),
Review comment:
Can you add a note on if its possible to do rolling updates with these
changes and how to do it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
