clintropolis commented on a change in pull request #8303: Enable code coverage
URL: https://github.com/apache/incubator-druid/pull/8303#discussion_r314934485
##########
File path: pom.xml
##########
@@ -973,13 +973,33 @@
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>cobertura-maven-plugin</artifactId>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <version>0.8.4</version>
+ <configuration>
+ <excludes>
+ <!-- Ignore generated code -->
+
<exclude>org/apache/druid/math/expr/antlr/Expr*</exclude> <!-- core -->
+
<exclude>org/apache/druid/**/generated/*Benchmark*</exclude> <!-- benchmarks
-->
+
<exclude>org/apache/druid/data/input/influx/InfluxLineProtocol*</exclude> <!--
extensions-contrib/influx-extensions -->
Review comment:
I wonder if maybe we should ignore all of benchmarks instead of just the
generated stuff, and also integration-tests since neither contain production
code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
