jihoonson commented on issue #8319: string column handling for long/float min/max/sum aggregators URL: https://github.com/apache/incubator-druid/pull/8319#issuecomment-523236410 @himanshug I will take a look probably sometime this week. In the meantime, would you check the CI failure? It looks legit. ``` [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.029 s <<< FAILURE! - in org.apache.druid.query.groupby.epinephelinae.ParallelCombinerTest [ERROR] testCombine(org.apache.druid.query.groupby.epinephelinae.ParallelCombinerTest) Time elapsed: 0.02 s <<< ERROR! java.lang.UnsupportedOperationException at org.apache.druid.query.groupby.epinephelinae.ParallelCombiner$SettableColumnSelectorFactory.getColumnCapabilities(ParallelCombiner.java:502) at org.apache.druid.query.aggregation.SimpleLongAggregatorFactory.shouldUseStringColumnAggregatorWrapper(SimpleLongAggregatorFactory.java:222) at org.apache.druid.query.aggregation.SimpleLongAggregatorFactory.factorizeBuffered(SimpleLongAggregatorFactory.java:97) at org.apache.druid.query.aggregation.SimpleLongAggregatorFactory.factorizeBuffered(SimpleLongAggregatorFactory.java:48) at org.apache.druid.query.aggregation.NullableAggregatorFactory.factorizeBuffered(NullableAggregatorFactory.java:52) at org.apache.druid.query.groupby.epinephelinae.StreamingMergeSortedGrouper.<init>(StreamingMergeSortedGrouper.java:145) at org.apache.druid.query.groupby.epinephelinae.ParallelCombiner.runCombiner(ParallelCombiner.java:392) at org.apache.druid.query.groupby.epinephelinae.ParallelCombiner.buildCombineTree(ParallelCombiner.java:348) at org.apache.druid.query.groupby.epinephelinae.ParallelCombiner.combine(ParallelCombiner.java:164) at org.apache.druid.query.groupby.epinephelinae.ParallelCombinerTest.testCombine(ParallelCombinerTest.java:117) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75) at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
