jihoonson commented on a change in pull request #8304: Add group_id to the
sys.tasks table
URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r316355604
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitorTest.java
##########
@@ -195,6 +195,7 @@ public TaskStatusResponse getTaskStatus(String taskId)
return new TaskStatusResponse(
taskId,
new TaskStatusPlus(
+ taskId,
Review comment:
I guess it might be fine to use the `taskId` as the `groupId` since the
[default value of `groupId` is the
`taskId`](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java#L75).
But, since `TaskMonitor` is used to monitor sub tasks of the parallel indexing
task, it could be more realistic to use the groupId of the taskId of the
supervisor task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
