gianm commented on issue #8349: Fix ClassCastException for TopN with long-type dimension URL: https://github.com/apache/incubator-druid/pull/8349#issuecomment-524059139 Hmm, that's a good point. I think given those facts, a test of DimValHolder would be sufficient for this patch, even though it doesn't test the original bug situation. Perhaps in the future we could consider testing this class of bugs through a more powerful integration testing framework.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
