himanshug commented on a change in pull request #8373: Speed up
ExpressionSelectors.makeExprEvalSelector
URL: https://github.com/apache/incubator-druid/pull/8373#discussion_r316894515
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -338,8 +336,8 @@ public BindingDetails withScalarArguments(Set<Expr>
scalarArguments)
{
Set<IdentifierExpr> moreScalars = new HashSet<>();
for (Expr expr : scalarArguments) {
- final IdentifierExpr stringIdentifier =
expr.getIdentifierExprIfIdentifierExpr();
- if (stringIdentifier != null) {
+ final boolean isIdentiferExpr =
expr.getIdentifierExprIfIdentifierExpr() != null;
+ if (isIdentiferExpr) {
Review comment:
I still think original version was good enough, but I see that the reasoning
as well. I think following could be best of both worlds. but all this is
probably nit now.
```
if (expr.getIdentifierExprIfIdentifierExpr() != null) {
..
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
