jihoonson commented on a change in pull request #8350: Fix the shuffle with TLS
enabled for parallel indexing; add an integration test; improve unit tests
URL: https://github.com/apache/incubator-druid/pull/8350#discussion_r316942640
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexTuningConfig.java
##########
@@ -105,7 +105,7 @@ public ParallelIndexTuningConfig(
@JsonProperty("maxRowsInMemory") @Nullable Integer maxRowsInMemory,
@JsonProperty("maxBytesInMemory") @Nullable Long maxBytesInMemory,
@JsonProperty("maxTotalRows") @Deprecated @Nullable Long maxTotalRows,
- @JsonProperty("numShards") @Nullable Integer numShards,
+ @JsonProperty("numShards") @Deprecated @Nullable Integer numShards,
Review comment:
It's already mentioned in the doc. I just added a missing annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
