xvrl commented on a change in pull request #8391: Fix
ConcurrentModificationException in JDK11
URL: https://github.com/apache/incubator-druid/pull/8391#discussion_r317373890
##########
File path:
processing/src/main/java/org/apache/druid/segment/QueryableIndexColumnSelectorFactory.java
##########
@@ -124,27 +130,32 @@ private DimensionSelector
makeDimensionSelectorUndecorated(DimensionSpec dimensi
@Override
public ColumnValueSelector<?> makeColumnValueSelector(String columnName)
{
- return valueSelectorCache.computeIfAbsent(
- columnName,
- name -> {
- if (virtualColumns.exists(columnName)) {
- ColumnValueSelector<?> selector =
virtualColumns.makeColumnValueSelector(columnName, index, offset);
- if (selector == null) {
- return virtualColumns.makeColumnValueSelector(columnName, this);
- } else {
- return selector;
- }
- }
+ Function<String, ColumnValueSelector<?>> mappingFunction = name -> {
+ if (virtualColumns.exists(columnName)) {
+ ColumnValueSelector<?> selector =
virtualColumns.makeColumnValueSelector(columnName, index, offset);
+ if (selector == null) {
+ return virtualColumns.makeColumnValueSelector(columnName, this);
+ } else {
+ return selector;
+ }
+ }
- BaseColumn column = getCachedColumn(columnName, BaseColumn.class);
+ BaseColumn column = getCachedColumn(columnName, BaseColumn.class);
- if (column != null) {
- return column.makeColumnValueSelector(offset);
- } else {
- return NilColumnValueSelector.instance();
- }
- }
- );
+ if (column != null) {
+ return column.makeColumnValueSelector(offset);
+ } else {
+ return NilColumnValueSelector.instance();
+ }
+ };
+
+ ColumnValueSelector<?> columnValueSelector =
valueSelectorCache.get(columnName);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
