gianm commented on a change in pull request #8392: Do not assume system
classloader is URLClassLoader in Java 9+
URL: https://github.com/apache/incubator-druid/pull/8392#discussion_r317375349
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java
##########
@@ -138,14 +141,22 @@ public static ClassLoader buildClassLoader(final
List<String> hadoopDependencyCo
?
hadoopDependencyCoordinates
:
defaultHadoopCoordinates;
- final List<URL> jobURLs = Lists.newArrayList(
- Arrays.asList(((URLClassLoader)
HadoopIndexTask.class.getClassLoader()).getURLs())
- );
+ ClassLoader taskClassLoader = HadoopIndexTask.class.getClassLoader();
Review comment:
May be nice to move this to something like `JvmUtils.systemClassPath()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
