leventov commented on a change in pull request #8359: Logging emitter to publish query and other metric events as valid json objects URL: https://github.com/apache/incubator-druid/pull/8359#discussion_r317503095
########## File path: server/src/main/java/org/apache/druid/server/log/DefaultRequestLogEventBuilderFactory.java ########## @@ -32,6 +32,11 @@ private static final DefaultRequestLogEventBuilderFactory INSTANCE = new DefaultRequestLogEventBuilderFactory(); @JsonCreator + public static DefaultRequestLogEventBuilderFactory instance(String ignored) Review comment: Why added this method in this PR? If this is the default factory, why would anybody want to specify `druid.request.logging.requestLogEventBuilderFactory=xyz` in the config? Please clarify both Javadoc and the PR description about this. Also, please add instructions for Druid cluster operators regarding this PR (what configs should be changed, what existing things could break.) Adding something to Druid's documentation might also be needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
