leventov commented on a change in pull request #7938: locking in Theta sketch
buffer aggregator
URL: https://github.com/apache/incubator-druid/pull/7938#discussion_r317994822
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildBufferAggregator.java
##########
@@ -42,16 +43,13 @@
public class HllSketchBuildBufferAggregator implements BufferAggregator
{
- /** for locking per buffer position (power of 2 to make index computation
faster) */
- private static final int NUM_STRIPES = 64;
-
private final ColumnValueSelector<Object> selector;
private final int lgK;
private final TgtHllType tgtHllType;
private final int size;
private final IdentityHashMap<ByteBuffer, WritableMemory> memCache = new
IdentityHashMap<>();
private final IdentityHashMap<ByteBuffer, Int2ObjectMap<HllSketch>>
sketchCache = new IdentityHashMap<>();
Review comment:
It seems that this field is not really a "cache". The corresponding field in
`SketchBufferAggregator` is called "unions". Maybe call it "sketches".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
