leventov commented on a change in pull request #7938: locking in Theta sketch
buffer aggregator
URL: https://github.com/apache/incubator-druid/pull/7938#discussion_r317993101
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchBufferAggregator.java
##########
@@ -40,6 +44,7 @@
private final int maxIntermediateSize;
private final IdentityHashMap<ByteBuffer, Int2ObjectMap<Union>> unions = new
IdentityHashMap<>();
Review comment:
Please also add all the necessary `@GuardedBy("stripedLock")` annotations to
fields and methods in other Aggregator classes changed in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
