clintropolis commented on a change in pull request #8400: enable unit tests
with JDK11
URL: https://github.com/apache/incubator-druid/pull/8400#discussion_r318339232
##########
File path: .travis.yml
##########
@@ -47,31 +47,40 @@ env:
# output. To compensate, use travis_wait to extend the timeout.
install: MAVEN_OPTS='-Xmx3000m' travis_wait 15 ${MVN} clean install -q -ff
${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C
-matrix:
- include:
- - name: "java 11 build"
- jdk: openjdk11
- script: ${MVN} test -pl '!web-console' ${MAVEN_SKIP}
+stages:
Review comment:
Stages might be reasonable so we use less CI time. I stumbled on [this
apache list somehow a couple weeks
ago](https://lists.apache.org/thread.html/b84bb9ecfb259618f0ed6830cc7b5a35b6f4578d5e8bcd76e7a24d70@%3Cbuilds.apache.org%3E)
which indicates that maybe we use a fair bit 😅
I personally don't find the longer overall time especially problematic,
review tends to happen on the weeks to months scale, so what is an hour here or
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
