gianm commented on issue #8230: Fix dependency analyze warnings URL: https://github.com/apache/incubator-druid/pull/8230#issuecomment-525805169 @ccaominh I looked at the first couple of extensions and at `lib` & had the following comments. Some of the changes look suspicious. Could you please review these and also check for similar suspicious things in the other extensions? > Only in before/extensions/druid-avro-extensions: avro-1.9.0.jar Suspicious because the avro extension should include avro. > Only in after/extensions/druid-avro-extensions: slf4j-api-1.7.25.jar Suspicious because slf4j-api should be provided by core & not needed in extensions. > Only in after/extensions/druid-datasketches: guava-16.0.1.jar Suspicious because guava should be provided by core & not needed in extensions. > Only in after/extensions/druid-datasketches: jsr305-2.0.1.jar Suspicious because jsr305 should be provided by core & not needed in extensions. > Only in after/extensions/druid-hdfs-storage: guava-16.0.1.jar > Only in after/extensions/druid-hdfs-storage: guice-4.1.0.jar > Only in after/extensions/druid-hdfs-storage: guice-servlet-4.1.0.jar Should all be provided by core. > Only in after/extensions/druid-hdfs-storage: log4j-1.2.17.jar log4j shouldn't be included; Druid uses log4j2 for logging. If we have dependencies that are written against log4j then we should swap in `log4j-over-slf4j` instead (see https://www.slf4j.org/legacy.html). > Only in after/extensions/druid-hdfs-storage: netty-3.10.6.Final.jar Should be provided by core. > Only in before/extensions/druid-hdfs-storage: okhttp-2.4.0.jar > Only in before/extensions/druid-hdfs-storage: okio-1.4.0.jar Mildly suspicious to me, since I don't know what these do or if they're necessary. > Only in after/extensions/druid-hdfs-storage: slf4j-api-1.7.25.jar > Only in after/extensions/druid-hdfs-storage: slf4j-log4j12-1.7.10.jar Should be provided by core. > Only in before/lib: commons-cli-1.3.1.jar This was removed -- were we not using it? > Only in after/lib: commons-lang3-3.7.jar > Only in before/lib: commons-lang3-3.8.1.jar Why the downgrade? > Only in before/lib: commons-pool-1.6.jar Were we not using this? > Only in before/lib: netty-all-4.1.30.Final.jar Were we not using this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
