ccaominh commented on a change in pull request #8373: Speed up
ExpressionSelectors.makeExprEvalSelector
URL: https://github.com/apache/incubator-druid/pull/8373#discussion_r318681732
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -416,6 +414,19 @@ public BindingDetails removeLambdaArguments(Set<String>
lambda)
isOutputArray
);
}
+
+ // Use this instead of streams for better performance
+ private static Set<String> map(
+ Set<IdentifierExpr> variables,
+ java.util.function.Function<IdentifierExpr, String> mapper
+ )
+ {
+ Set<String> results = new HashSet<>(variables.size());
Review comment:
Cool, didn't know about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
