SandishKumarHN commented on a change in pull request #8394: 8156 :
StructuralSearchInspection, Prohibit check on Thread.getState()
URL: https://github.com/apache/incubator-druid/pull/8394#discussion_r318773966
##########
File path: .idea/inspectionProfiles/Druid.xml
##########
@@ -311,6 +311,16 @@
<constraint name="k" within="" contains="" />
<constraint name="v" within="" contains="" />
</searchConfiguration>
+ <searchConfiguration name="Prohibit Thread.getState() != TERMINATED
antipattern" text="$t$.getState()!=Thread.State.$state$" recursive="true"
caseInsensitive="true" type="JAVA">
+ <constraint name="t" within="" contains="" />
+ <constraint name="state" within="" contains="" />
+ <constraint name="t1" within="" contains="" />
Review comment:
@leventov changed via IntelliJ and always tested by adding wrong snippets,
it never throwed error for t1, t1 was from old changes, fixed now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
