swapneshgandhi commented on a change in pull request #8272: Support incremental
load in Druid lookups
URL: https://github.com/apache/incubator-druid/pull/8272#discussion_r319303876
##########
File path:
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/JdbcCacheGenerator.java
##########
@@ -74,6 +74,14 @@
final String keyColumn = namespace.getKeyColumn();
LOG.debug("Updating %s", entryId);
+
+ boolean doIncrementalLoad = lastDBUpdate != null &&
!Strings.isNullOrEmpty(namespace.getTsColumn())
Review comment:
As current Druid docs on lookups say, this change only kicks in if user
explicitly sets `tsColumn` in the lookup config. So its not really kicking in
unless user sets the `tsColumn`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
