jon-wei commented on a change in pull request #8465: disallow whitespace
characters in data source names
URL: https://github.com/apache/incubator-druid/pull/8465#discussion_r320995376
##########
File path:
server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -74,6 +74,9 @@ public DataSchema(
Preconditions.checkArgument(!Strings.isNullOrEmpty(dataSource),
"dataSource cannot be null or empty. Please provide a dataSource.");
Preconditions.checkArgument(!dataSource.contains("/"), "dataSource cannot
contain the '/' character.");
+ Preconditions.checkArgument(!dataSource.contains("\t"), "dataSource cannot
contain the '\\t' character.");
Review comment:
Suggest extracting these checks into a static method on DataSchema, could
call it `validateDatasourceName`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
