ccaominh commented on a change in pull request #8458: Exit JVM on curator
unhandled errors
URL: https://github.com/apache/incubator-druid/pull/8458#discussion_r321032619
##########
File path: server/pom.xml
##########
@@ -265,6 +265,11 @@
<artifactId>JUnitParams</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stefanbirkner</groupId>
+ <artifactId>system-rules</artifactId>
Review comment:
The ASF guidance for "weak copyleft" licenses (like CPLv1.0) requires the
inclusion to be appropriately labeled:
- https://apache.org/legal/resolved.html#weak-copyleft-licenses
- https://apache.org/legal/resolved.html#appropriately-labelled-condition
Note that EPLv1.0 is a "weak copyleft" license and is the license for
JUnit4: https://junit.org/junit4/license.html. I can't find anything in the
druid repo that satisfies the "Appropriate labelled condition" for JUnit4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
