ccaominh commented on a change in pull request #8465: disallow whitespace characters in data source names URL: https://github.com/apache/incubator-druid/pull/8465#discussion_r321452255
########## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ########## @@ -41,6 +41,8 @@ import java.util.HashSet; import java.util.Map; import java.util.Set; +import java.util.regex.*; Review comment: Checkstyle forbids wildcard imports: https://github.com/apache/incubator-druid/blob/6a6893b40664a07f7ef8c510c69b22b4b98d955b/codestyle/checkstyle.xml#L60 You can run checkstyle locally, for example via `mvn checkstyle:checkstyle`: https://maven.apache.org/plugins/maven-checkstyle-plugin/usage.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
