leventov commented on issue #8492: Improper Appenderator.add() calls concurrent with persist URL: https://github.com/apache/incubator-druid/issues/8492#issuecomment-529918478 First of all, your comment should belong to the codebase in some form. Second, it's hard to prove that the previous block which may add hydrants to `indexesToPersist` list is free of race conditions with some code updating (or not updating) `Sink.writable` field: https://github.com/apache/incubator-druid/blob/762f4d0e58b0f62c4225d978ab0d49509eb3598c/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java#L551-L558 "Hard to prove" is already a defect actually. The codebase must not contain anything that requires a concurrency "proof". These "proofs" should be elaborated in very detailed comments (these comments must look a little more verbose than needed when you write them, otherwise they are not verbose enough).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
