ccaominh commented on a change in pull request #8484: Web console: Druid status
displayed in a table
URL: https://github.com/apache/incubator-druid/pull/8484#discussion_r322869932
##########
File path: web-console/src/dialogs/status-dialog/status-dialog.tsx
##########
@@ -99,7 +99,7 @@ export class StatusDialog extends
React.PureComponent<StatusDialogProps, StatusD
filterable
defaultFilterMethod={(filter, row) => {
const id = filter.pivotId || filter.id;
- return row[id] !== undefined ?
String(row[id]).includes(filter.value) : true;
+ return row[id] !== undefined ?
String(row[id]).includes(filter.value) : false;
Review comment:
Is it worth adding a unit test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
