jon-wei commented on a change in pull request #8507: Rename partition spec
fields
URL: https://github.com/apache/incubator-druid/pull/8507#discussion_r325905385
##########
File path:
core/src/main/java/org/apache/druid/indexer/partitions/HashedPartitionsSpec.java
##########
@@ -50,15 +51,18 @@ public HashedPartitionsSpec(
@Nullable List<String> partitionDimensions
)
{
- this(null, maxRowsPerSegment, numShards, partitionDimensions);
+ this(maxRowsPerSegment, numShards, partitionDimensions, null);
}
@JsonCreator
public HashedPartitionsSpec(
- @JsonProperty("targetPartitionSize") @Deprecated @Nullable Integer
targetPartitionSize,
- @JsonProperty("maxRowsPerSegment") @Nullable Integer maxRowsPerSegment,
+ @JsonProperty(PartitionsSpec.MAX_ROWS_PER_SEGMENT) @Nullable Integer
maxRowsPerSegment,
Review comment:
For consistency with the single dim spec, it seems like it would be better
to call this `targetRowsPerSegment` to match `targetPartitionSize`, but that
would mean deprecating yet another property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
