renevan10 commented on a change in pull request #8537: Web console: Add
frontend buttons to remove group by
URL: https://github.com/apache/incubator-druid/pull/8537#discussion_r327386338
##########
File path:
web-console/src/views/query-view/column-tree/column-tree-menu/string-menu-items/string-menu-items.spec.tsx
##########
@@ -37,4 +37,17 @@ describe('string menu', () => {
const { container } = render(stringMenu);
expect(container.firstChild).toMatchSnapshot();
});
+
+ it('matches snapshot containing remove group by button', () => {
+ const stringMenu = (
+ <StringMenuItems
+ columnName={'channel'}
+ parsedQuery={parser(`SELECT channel, count(*) as cnt FROM wikipedia
GROUP BY 1`)}
Review comment:
I've made changes to the tests per our discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
