clintropolis commented on a change in pull request #8426: groupBy query:
optional limit push down to segment scan
URL: https://github.com/apache/incubator-druid/pull/8426#discussion_r325923562
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java
##########
@@ -220,6 +229,10 @@ public GroupByQueryConfig withOverrides(final
GroupByQuery query)
getMaxMergingDictionarySize()
);
newConfig.forcePushDownLimit =
query.getContextBoolean(CTX_KEY_FORCE_LIMIT_PUSH_DOWN, isForcePushDownLimit());
+ newConfig.forcePushDownLimit = query.getContextBoolean(
Review comment:
Should this be setting `applyLimitPushDownToSegment` instead of
`forcePushDownLimit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
