mitchlloyd opened a new pull request #8651: Add credentials for ECS URL: https://github.com/apache/incubator-druid/pull/8651 Fixes #8559. ### Description Allow Druid to fetch credentials from within an ECS container on AWS. I added an instance of `EC2ContainerCredentialsProviderWrapper` which seems to be the fully baked way to get credentials on ECS with the SDK. I first tried adding `new ContainerCredentialsProvider()` but saw that constructor was deprecated. Despite `EC2` in the name, I believe this should work for ECS Fargate as well. I noticed [a similar change in the Hadoop project](https://github.com/apache/hadoop/pull/413). I also noticed that the line below (`new InstanceProfileCredentialsProvider()`) was showing a deprecation warning in my editor. [The docs](https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/InstanceProfileCredentialsProvider.html) say that this constructor had been deprecated in favor of the `.getInstance` method on the same class. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. I can test this change in a development Druid cluster. I noticed that there are no unit tests for this class, but unit tests don't seem like a good fit. I'd be happy to add onto any integration tests that I may have missed. <hr> ##### Key changed/added classes in this PR * AWSCredentialsUtils
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
