jon-wei commented on a change in pull request #8644: Fix Kinesis resharding 
issues
URL: https://github.com/apache/incubator-druid/pull/8644#discussion_r332798417
 
 

 ##########
 File path: 
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
 ##########
 @@ -1830,6 +1847,11 @@ protected String generateSequenceName(
 
   protected abstract String baseTaskName();
 
+  protected void cleanupDeadShards(Set<PartitionIdType> expiredShards)
+  {
 
 Review comment:
   From addressing 
https://github.com/apache/incubator-druid/pull/8644#discussion_r332606065, this 
is now `createDataSourceMetadataWithoutExpiredPartitions` with javadocs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to