leventov commented on a change in pull request #8564: 
IndexerSQLMetadataStorageCoordinator.getTimelineForIntervalsWithHandle() don't 
fetch abutting intervals; Simplify getUsedSegmentsForIntervals()
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r333906724
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
 ##########
 @@ -125,14 +124,7 @@ public void start()
               intervals
           );
 
-          return intervals
-              .stream()
-              .flatMap((Interval interval) -> 
timeline.lookup(interval).stream())
-              .flatMap(timelineObjectHolder -> {
-                return 
StreamSupport.stream(timelineObjectHolder.getObject().payloads().spliterator(), 
false);
-              })
-              .distinct()
-              .collect(Collectors.toList());
+          return new ArrayList<>(timeline.iterateAllObjects());
 
 Review comment:
   It doesn't matter because the result of this method is a collection of 
objects, not holders.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to