leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583652
##########
File path:
core/src/main/java/org/apache/druid/java/util/emitter/EmittingLogger.java
##########
@@ -40,6 +40,7 @@
public static final String EXCEPTION_MESSAGE_KEY = "exceptionMessage";
public static final String EXCEPTION_STACK_TRACE_KEY = "exceptionStackTrace";
+ @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final
because set in an initializer block
Review comment:
Same problem here, the comment doesn't reflect the reality.
registerEmitter() is the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
