gianm commented on a change in pull request #8666: resolve resolveip command 
not found issue in integration test
URL: https://github.com/apache/incubator-druid/pull/8666#discussion_r336684977
 
 

 ##########
 File path: integration-tests/docker/Dockerfile
 ##########
 @@ -86,4 +86,4 @@ EXPOSE 8300 8301 8302 8303 8304 8305
 EXPOSE 9092 9093
 
 WORKDIR /var/lib/druid
-ENTRYPOINT export HOST_IP="$(resolveip -s $HOSTNAME)" && 
/tls/generate-server-certs-and-keystores.sh && exec /usr/bin/supervisord -c 
/etc/supervisor/conf.d/supervisord.conf
+ENTRYPOINT export HOST_IP="$(curl ifconfig.me)" && 
/tls/generate-server-certs-and-keystores.sh && exec /usr/bin/supervisord -c 
/etc/supervisor/conf.d/supervisord.conf
 
 Review comment:
   This needs an internet connection, and relies on an external web service 
that might go away. I think we can do it without needing one. How about:
   
   ```
   host `hostname` | perl -nle '/has address (.*)/ && print $1'
   ```
   
   The two most common dns lookup commands AFAIK are `host` and `dig`, so 
probably either one would be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to