gkc2104 opened a new pull request #8699: GCS doc fix for bucket prefix URL: https://github.com/apache/incubator-druid/pull/8699 The property [druid.google.prefix](https://druid.apache.org/docs/latest/development/extensions-core/google.html#configuration) can be left empty and is not a hard requirement. After a deployment in hindsight realized we never set this property and neither did druid callout nor did we face any issues. It seems to be handled in [GoogleDataSegmentPusher.buildPath](https://github.com/gkc2104/incubator-druid/blob/gcs-doc-fix/extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentPusher.java#L140) at path creation time and the property is also not required to be [null](https://github.com/gkc2104/incubator-druid/blob/gcs-doc-fix/extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleAccountConfig.java#L32) Looking at the puller it doesn't seem like we should have problems with reading from deep storage either, unless I'm missing something. <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
