leventov commented on a change in pull request #8700: create new thread for
callback execution
URL: https://github.com/apache/incubator-druid/pull/8700#discussion_r337876881
##########
File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java
##########
@@ -496,7 +497,9 @@ public void onFailure(Throwable t)
}
}
}
- }
+ },
+ // create new thread for callback, since HttpClient is async
+ Execs.singleThreaded("CancelQuery-executor")
Review comment:
It now creates a thread pool on every request. Cache the thread pool in a
field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
