clintropolis opened a new pull request #8744: support for array expressions in TransformSpec with ExpressionTransform URL: https://github.com/apache/incubator-druid/pull/8744 Fixes #8733 (and likely #8613, but untested in this PR) ### Description This PR adds array expression support to `transformSpec`, filling in one of the remaining functionality gaps left from #7525. Additionally, this PR removes `ParseSpec.verify` since its' only use afaict was preventing transform expr that did not replace their input from functioning, because the implementations would complain about dimensions that were not mapped to a column, discovered when I was trying to add a test for the newly added array expression support of `ExpressionTransform`. Tagged with label release notes since in additional to fixing odd behavior with array expressions at indexing time, `ParseSpec.verify` was annotated `@PublicApi`, though since the only callers were the constructors of the `ParseSpec` that implemented the method, this shouldn't cause anything other than perhaps a complication issue for private extensions due to needing to remove `@Override` on the `verify` method. <hr> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added unit tests or modified existing tests to cover new code paths.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
