yuanlihan opened a new pull request #8758: Case sensitive comparison of 
nonbinary string in MySQL metadata storage
URL: https://github.com/apache/incubator-druid/pull/8758
 
 
   This PR fixes the issue caused by default case insensitive comparison of 
nonbinary string in MySQL metadata storage.
   
   
   ### Description
   When using MySQL as metadata storage, the default collation of specific 
character set for nonbinary string comparison is case insensitive.
   
   So there are problems when executing update statement if there are 
dataSources with different cases, like _dataSource_aaa_ and _dataSource_AAA_.
   For example, the update statement `UPDATE druid_segments SET used=false 
WHERE dataSource = 'dataSource_aaa'` will affect records of both 
_dataSource_aaa_ and _dataSource_AAA_.
   
   This PR fix this issue by add a COLLATE attribute of dataSource column when 
creating tables.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist above are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `SQLMetadataConnector`
    * `MySQLConnector`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to